Skip to content

fix: sync decorators #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: sync decorators #343

wants to merge 4 commits into from

Conversation

@Sobes76rus
Copy link
Contributor

@Sobes76rus Sobes76rus commented Jul 19, 2024

use case

@broker.task()
@validate_call()
async def task(arg1: str) -> None: ...

so, the thing is that pydantic's validator_call is syncronious decorator which returns awaitable future after call
right now receiver can't work with sync decorators on async functions

s3rius
s3rius reviewed Jul 19, 2024
View reviewed changes
@Sobes76rus Sobes76rus requested a review from s3rius July 19, 2024 16:47
@Sobes76rus
Copy link
Contributor Author

Sobes76rus commented Aug 27, 2024

@s3rius all done as you suggested

s3rius
s3rius previously approved these changes Nov 22, 2025
View reviewed changes
@s3rius s3rius changed the base branch from develop to master November 22, 2025 21:42
@s3rius s3rius dismissed their stale review November 22, 2025 21:42

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s3rius s3rius s3rius left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sobes76rus @s3rius